clean AsciiDoc (master) #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
graphitefriction
commented
Aug 17, 2018
graphitefriction
commented
- fix titles and remove extra lines
- remove quote blocks and add admonitions
- remove indents/spaces from tables and add implicit headers
- remove unconstrained inline formatting
- simplify lists
- remove unneeded escapes
- remove attribute files
- convert link:$$$.html to xref:$$$.adoc
- add GIF to assets - fix image name
Contributor
|
@graphitefriction those are wonderful changes! One question, I noticed this PR adds explicit title ids. For example: I'm wondering if it's really needed here? |
Contributor
|
My preference would be to auto-generate the title IDs with hyphens instead of underscores. So I use the following on my local Antora config to do that: |
Contributor
Author
|
@jamiltz I can definitely remove the explicit IDs (I added them out of habit because I tweak section titles constantly in my own writing and hate grepping through all the rest of the pages to fix the links I broke 😝 ) I agree 100% with putting the AsciiDoc attributes in the playbook. @mojavelinux is concerned that there may be a few ID collisions when applied across the whole migration set, so he's doing a test run. If there aren't massive conflicts, we'll add the attributes to the production and staging playbooks and remove the attributes from the document headers (DRY FTW!) |
Contributor
|
Sounds good. Thanks! :) |
Contributor
Author
|
@jamiltz I removed the explicit IDs and updated the PR. For now, the id attributes are in the headers of the targeted documents. Dan's got a big N1QL reference document with colliding IDs he has to debug before the attrs can be added to the playbook. |
Contributor
|
Ok! |
Contributor
|
Thanks James! |
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 26, 2021
Set new issues list entries (cherry picked from commit 91feb5b98468b1e3129cbce43237792e4efe75a2)
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 26, 2021
Set new issues list entries (cherry picked from commit 91feb5b98468b1e3129cbce43237792e4efe75a2)
ibsoln
added a commit
that referenced
this pull request
Oct 26, 2021
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 26, 2021
https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (couchbase#4) Set new issues list entries
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 26, 2021
https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (couchbase#4) Set new issues list entries (cherry picked from commit 4d57eff)
ibsoln
added a commit
that referenced
this pull request
Oct 26, 2021
https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (#4) Set new issues list entries (cherry picked from commit 4d57eff)
ibsoln
added a commit
that referenced
this pull request
Oct 26, 2021
https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (#4) Set new issues list entries
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 26, 2021
Includes release notes an dminor supporting changes https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#597) https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (couchbase#4) Set new issues list entries (cherry picked from commit 122d375) DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 (cherry picked from commit 1f93a1bb4ad311081b53bc403b0562f6b26674be)
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 26, 2021
Includes release notes an dminor supporting changes https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#597) https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (couchbase#4) Set new issues list entries (cherry picked from commit 122d375) DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 (cherry picked from commit 1f93a1bb4ad311081b53bc403b0562f6b26674be)
ibsoln
added a commit
to ibsoln/docs-sync-gateway
that referenced
this pull request
Oct 27, 2021
Includes release notes an dminor supporting changes https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#597) https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (couchbase#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (couchbase#4) Set new issues list entries (cherry picked from commit 122d375) DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 (cherry picked from commit 1f93a1bb4ad311081b53bc403b0562f6b26674be)
ibsoln
added a commit
that referenced
this pull request
Oct 28, 2021
* DOC-9307 -- Release Notes for 2.8.3 Includes release notes an dminor supporting changes https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#597) https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#2) Feedback applied. https://issues.couchbase.com/browse/DOC-9307 DOC-9307 -- Release Notes for 2.8.3 (#3) Set new issues list entries (cherry picked from commit df5120b27862a4b7880c3b69f0454f16cc80d22c) (cherry picked from commit a812f46) DOC-9307 -- Release Notes for 2.8.3 (#4) Set new issues list entries (cherry picked from commit 122d375) DOC-9307 -- Release Notes for 2.8.3 https://issues.couchbase.com/browse/DOC-9307 (cherry picked from commit 1f93a1bb4ad311081b53bc403b0562f6b26674be) * QF211027-1 -- Fix mislabelled image links (cherry picked from commit 5b442f61eca3195a72646605ac90f97fa9b0dcec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.